4.json (2160B)
1 { 2 "number": 4, 3 "title": "Make bot compile and add dockerfile", 4 "state": "merged", 5 "diff_file": "4.diff", 6 "author": "freaktechnik", 7 "created_at": "2020-08-15T19:04:32Z", 8 "closed_at": "2020-08-15T19:30:40Z", 9 "merged_at": "2020-08-15T19:30:40Z", 10 "base_ref": "master", 11 "head_ref": "master", 12 "labels": [], 13 "assignees": [ 14 "MTRNord" 15 ], 16 "requested_reviewers": [], 17 "body": "In order to use the bot I needed it to be packaged in a docker container, so I created a dockerfile. I've also fixed it not compiling, presumably due to some tiny silly library update. If you don't want the Dockerfile in this repo that's fine. I'll happily open a PR just with the compile fix.\r\n\r\nI think the usage example is also no longer accurate, I needed to do `auto-invite-matrix-bot --config=/path/to/config.yml`.", 18 "comments": [ 19 { 20 "author": "MTRNord", 21 "created_at": "2020-08-15T19:30:21Z", 22 "body": "Hi thanks for making the PR. The usage example says the same as you have there. It might be `yml` vs `yaml`. The longer version is used as the default while tbh the shorter version is more common." 23 }, 24 { 25 "author": "freaktechnik", 26 "created_at": "2020-08-15T19:32:12Z", 27 "body": "No, the usage sample crucially shows `--config /path/to/config.yml` without the `=` which leads to the args parsing failing rather cryptically." 28 }, 29 { 30 "author": "MTRNord", 31 "created_at": "2020-08-15T19:51:26Z", 32 "body": "Hm what example are you referring to? The readme only contains this line about it: `Run it with auto-invite-matrix-bot with an addition --config argument to point to your config file` do you mean the `--help` one? Thats from the clap dependency. Might be a bug on their side or a compatibility issue with the terminal you are using" 33 }, 34 { 35 "author": "freaktechnik", 36 "created_at": "2020-08-15T20:03:01Z", 37 "body": "Probably the --help one - I assume that's what they output if the parsing of arguments fails. I found out via tgeir docs that they expect the = for long form. I guess that's a bug in the lib then, indeed." 38 } 39 ], 40 "review_comments": [] 41 }