auto-invite-matrix-bot.meta

Issues/PRs archive for MTRNord/auto-invite-matrix-bot
git clone git://archive.git.mtrnord.blog/MTRNord/auto-invite-matrix-bot.meta.git
Log | Files | Refs

4.md (1742B)


      1 # PR #4 Make bot compile and add dockerfile
      2 
      3 - **Status:** merged
      4 - **Author:** @freaktechnik
      5 - **Created:** 2020-08-15T19:04:32Z
      6 - **Branch:** master → master
      7 - **Merged:** 2020-08-15T19:30:40Z
      8 - **Assignees:** @MTRNord
      9 - **Diff:** [4.diff](./4.diff)
     10 
     11 ---
     12 
     13 In order to use the bot I needed it to be packaged in a docker container, so I created a dockerfile. I've also fixed it not compiling, presumably due to some tiny silly library update. If you don't want the Dockerfile in this repo that's fine. I'll happily open a PR just with the compile fix.
     14 
     15 I think the usage example is also no longer accurate, I needed to do `auto-invite-matrix-bot --config=/path/to/config.yml`.
     16 
     17 
     18 ## Comments
     19 
     20 ### @MTRNord — 2020-08-15T19:30:21Z
     21 
     22 Hi thanks for making the PR. The usage example says the same as you have there. It might be `yml` vs `yaml`. The longer version is used as the default while tbh the shorter version is more common.
     23 
     24 ### @freaktechnik — 2020-08-15T19:32:12Z
     25 
     26 No, the usage sample crucially shows `--config /path/to/config.yml` without the `=` which leads to the args parsing failing rather cryptically.
     27 
     28 ### @MTRNord — 2020-08-15T19:51:26Z
     29 
     30 Hm what example are you referring to? The readme only contains this line about it: `Run it with auto-invite-matrix-bot with an addition --config argument to point to your config file` do you mean the `--help` one? Thats from the clap dependency. Might be a bug on their side or a compatibility issue with the terminal you are using
     31 
     32 ### @freaktechnik — 2020-08-15T20:03:01Z
     33 
     34 Probably the --help one - I assume that's what they output if the parsing of arguments fails. I found out via tgeir docs that they expect the = for long form. I guess that's a bug in the lib then, indeed.
     35