heic2jpg.meta

Issues/PRs archive for MTRNord/heic2jpg
git clone git://archive.git.mtrnord.blog/MTRNord/heic2jpg.meta.git
Log | Files | Refs

2.json (1890B)


      1 {
      2   "number": 2,
      3   "title": "feat: adjust design to follow GNOME HIG",
      4   "state": "merged",
      5   "diff_file": "2.diff",
      6   "author": "FineFindus",
      7   "created_at": "2024-11-11T15:37:28Z",
      8   "closed_at": "2024-11-11T16:26:38Z",
      9   "merged_at": "2024-11-11T16:26:38Z",
     10   "base_ref": "main",
     11   "head_ref": "feat/HIG-design",
     12   "labels": [],
     13   "assignees": [],
     14   "requested_reviewers": [],
     15   "body": "Since the project uses libadwaita, I'm assuming the goal is to follow the [GNOME HIG](https://developer.gnome.org/hig/). I've slightly adjusted the design, to use suggested actions and [`Adw.ToolbarView`](https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/class.ToolbarView.html) to follow the HIG more closely.\r\nFurther improvements could include updating the pages to use [icons or illustrations](https://developer.gnome.org/hig/patterns/feedback/placeholders.html), adjusting the text.\r\nYou might want to take a look to at apps like [Switcheroo](https://flathub.org/apps/io.gitlab.adhami3310.Converter) or [Morphosis](https://flathub.org/apps/garden.jamie.Morphosis), which implement similar functionality.\r\n\r\n![Updated folder selection](https://github.com/user-attachments/assets/b7474548-a408-4687-b30e-6f4bc1ac155e)\r\n![Updated conversion screen](https://github.com/user-attachments/assets/1207a7c6-3843-4340-9912-4494a590b440)\r\n",
     16   "comments": [
     17     {
     18       "author": "MTRNord",
     19       "created_at": "2024-11-11T16:26:35Z",
     20       "body": "Thanks a lot for this. This was on the weekend, kinda written in a rush, so I didn't have yet time to do a \"Pretty Pass\". Also thanks for linking the GNOME HIG :) I will have a look at that. This PR is a very nice upgrade, however!\r\n\r\nI am aware of Switcheroo too (great app :D) and this kinda is for the batch processing usecase more. I will need to think about icons a little bit still. :)"
     21     }
     22   ],
     23   "review_comments": []
     24 }