mrsbfh.meta

Issues/PRs archive for MTRNord/mrsbfh
git clone git://archive.git.mtrnord.blog/MTRNord/mrsbfh.meta.git
Log | Files | Refs

5.json (991B)


      1 {
      2   "number": 5,
      3   "title": "Add lazy_static or equivalent to all regex objects used internally",
      4   "state": "closed",
      5   "author": "donicrosby",
      6   "created_at": "2021-11-08T20:18:07Z",
      7   "closed_at": "2021-11-13T14:41:38Z",
      8   "labels": [
      9     "enhancement"
     10   ],
     11   "assignees": [
     12     "MTRNord"
     13   ],
     14   "body": "In the regex library it recommends the use of the `lazy_static!` macro on regexs that are used frequently that are not changed during runtime.\r\n\r\nSee: https://docs.rs/regex/1.5.4/regex/#example-avoid-compiling-the-same-regex-in-a-loop\r\n\r\nWhile the regexs used in finding the command and removing whitespace aren't a huge load multiple commands coming in from a lot of rooms to a bot would mean those computations add up. Having those pre-compiled and ready to use would make the bot faster to respond to commands sent.",
     15   "comments": [
     16     {
     17       "author": "donicrosby",
     18       "created_at": "2021-11-10T03:37:46Z",
     19       "body": "Added support for this in #6 "
     20     }
     21   ]
     22 }