6.json (1634B)
1 { 2 "number": 6, 3 "title": "Regexs use lazy_static macro", 4 "state": "merged", 5 "diff_file": "6.diff", 6 "author": "donicrosby", 7 "created_at": "2021-11-10T02:16:53Z", 8 "closed_at": "2021-11-13T14:41:19Z", 9 "merged_at": "2021-11-13T14:41:19Z", 10 "base_ref": "main", 11 "head_ref": "use-lazy-static-macro", 12 "labels": [], 13 "assignees": [], 14 "requested_reviewers": [], 15 "body": "Added support for the bot to use pre-compiled regexs using the `lazy_static` macro", 16 "comments": [ 17 { 18 "author": "MTRNord", 19 "created_at": "2021-11-13T14:41:15Z", 20 "body": "LGTM. :)" 21 } 22 ], 23 "review_comments": [ 24 { 25 "author": "donicrosby", 26 "created_at": "2021-11-10T02:40:51Z", 27 "body": "Don't bring all of tokio to compile to keep the binary smaller and the build faster", 28 "path": "example-bot/Cargo.toml", 29 "line": 21, 30 "diff_hunk": "@@ -18,7 +18,7 @@ serde = \"1.0\"\n tracing = \"0.1\"\n tracing-subscriber = \"0.3.1\"\n tracing-futures = \"0.2.4\"\n-tokio = { version = \"1\", features = [\"full\"] }\n+tokio = { version = \"1\", features = [\"rt\", \"rt-multi-thread\", \"sync\", \"macros\"] }" 31 }, 32 { 33 "author": "donicrosby", 34 "created_at": "2021-11-10T03:46:23Z", 35 "body": "Same thing here", 36 "path": "mrsbfh/Cargo.toml", 37 "line": 26, 38 "diff_hunk": "@@ -23,7 +23,7 @@ thiserror = \"1.0\"\n # Command macros\n mrsbfh-macros = {version = \"0.2.0\", path = \"../mrsbfh-macros\", optional = true}\n \n-tokio = { version = \"1\", features = [\"full\"] }\n+tokio = { version = \"1\", features =[\"rt\", \"rt-multi-thread\", \"macros\"]}" 39 } 40 ] 41 }