mrsbfh.meta

Issues/PRs archive for MTRNord/mrsbfh
git clone git://archive.git.mtrnord.blog/MTRNord/mrsbfh.meta.git
Log | Files | Refs

6.md (1170B)

      1 # PR #6 Regexs use lazy_static macro
      2 
      3 - **Status:** merged
      4 - **Author:** @donicrosby
      5 - **Created:** 2021-11-10T02:16:53Z
      6 - **Branch:** use-lazy-static-macro → main
      7 - **Merged:** 2021-11-13T14:41:19Z
      8 - **Diff:** [6.diff](./6.diff)
      9 
     10 ---
     11 
     12 Added support for the bot to use pre-compiled regexs using the `lazy_static` macro
     13 
     14 
     15 ## Review comments
     16 
     17 ### @donicrosby on `example-bot/Cargo.toml`:21 — 2021-11-10T02:40:51Z
     18 
     19 ```diff
     20 @@ -18,7 +18,7 @@ serde = "1.0"
     21  tracing = "0.1"
     22  tracing-subscriber = "0.3.1"
     23  tracing-futures = "0.2.4"
     24 -tokio = { version = "1", features = ["full"] }
     25 +tokio = { version = "1", features = ["rt", "rt-multi-thread", "sync", "macros"] }
     26 ```
     27 
     28 Don't bring all of tokio to compile to keep the binary smaller and the build faster
     29 
     30 ### @donicrosby on `mrsbfh/Cargo.toml`:26 — 2021-11-10T03:46:23Z
     31 
     32 ```diff
     33 @@ -23,7 +23,7 @@ thiserror = "1.0"
     34  # Command macros
     35  mrsbfh-macros = {version = "0.2.0", path = "../mrsbfh-macros", optional = true}
     36  
     37 -tokio = { version = "1", features = ["full"] }
     38 +tokio = { version = "1", features =["rt", "rt-multi-thread", "macros"]}
     39 ```
     40 
     41 Same thing here
     42 
     43 
     44 ## Comments
     45 
     46 ### @MTRNord — 2021-11-13T14:41:15Z
     47 
     48 LGTM. :)
     49