15.json (1481B)
1 { 2 "number": 15, 3 "title": "Linkify types not working", 4 "state": "closed", 5 "author": "MTRNord", 6 "created_at": "2018-03-27T14:03:36Z", 7 "closed_at": "2018-04-11T10:15:38Z", 8 "labels": [ 9 "bug", 10 "Blocked Upstream" 11 ], 12 "assignees": [ 13 "MTRNord" 14 ], 15 "body": "Linkify isn't working because of these lines: https://github.com/SocialNetworkNews/SocialNetworkNews-Web/blob/dabfb2d71b1d72929be916ef95ba99d3f4cd8af2/src/app/tweet-list/tweet-list.component.ts#L15-L19\r\n\r\nUpstream Issue is opened at: https://github.com/SoapBox/linkifyjs/issues/227", 16 "comments": [ 17 { 18 "author": "nazarkryp", 19 "created_at": "2018-04-06T10:23:46Z", 20 "body": "Actually works:\r\n\r\n```\r\nimport * as linkify from 'linkifyjs';\r\nimport * as linkifyStr from 'linkifyjs/string';\r\nimport * as hashtag from 'linkifyjs/plugins/hashtag';\r\nimport * as mention from 'linkifyjs/plugins/mention';\r\n\r\n@Pipe({\r\n name: 'linkify'\r\n})\r\nexport class LinkifyPipe implements PipeTransform {\r\n constructor(\r\n @Inject(DOCUMENT) dom: Document) {\r\n hashtag(linkify);\r\n mention(linkify);\r\n }\r\n\r\n public transform(text: any): string {\r\n return linkifyStr(text);\r\n }\r\n}\r\n```" 21 }, 22 { 23 "author": "MTRNord", 24 "created_at": "2018-04-06T12:33:15Z", 25 "body": "Reopenening for the purpose to track having to type linkifyjs. linkifyjs types are not correct and let the build fail" 26 } 27 ] 28 }