25.json (3789B)
1 { 2 "number": 25, 3 "title": "Match refactor", 4 "state": "merged", 5 "diff_file": "25.diff", 6 "author": "jplatte", 7 "created_at": "2020-07-24T23:59:36Z", 8 "closed_at": "2020-07-25T00:10:13Z", 9 "merged_at": "2020-07-25T00:10:13Z", 10 "base_ref": "MTRNord/Redesign", 11 "head_ref": "match-refactor", 12 "labels": [], 13 "assignees": [], 14 "requested_reviewers": [], 15 "body": "", 16 "comments": [], 17 "review_comments": [ 18 { 19 "author": "MTRNord", 20 "created_at": "2020-07-25T00:06:14Z", 21 "body": "Why did you change this to false? It should update the event list on a new event. Or is just the git diff weird displayed?", 22 "path": "src/app/components/event_list.rs", 23 "line": 81, 24 "diff_hunk": "@@ -67,55 +67,50 @@ impl Component for EventList {\n \n fn update(&mut self, msg: Self::Message) -> bool {\n match msg {\n- Msg::NewMessage(response) => {\n- match response {\n- Response::Sync((room_id, raw_msg)) => {\n- // TODO handle all events\n- if let Ok(msg) = raw_msg.deserialize() {\n- if self.state.events.contains_key(&room_id) {\n- if !(self.state.events[&room_id]\n- .iter()\n- .any(|x| x.event_id() == msg.event_id()))\n- {\n- self.state.events.get_mut(&room_id).unwrap().push(msg);\n- room_id == self.props.current_room.room_id\n- } else {\n- false\n- }\n- } else {\n- let msgs = vec![msg];\n- self.state.events.insert(room_id.clone(), msgs);\n- room_id == self.props.current_room.room_id\n- }\n- } else {\n- false\n- }\n- }\n- Response::OldMessages((room_id, messages)) => {\n- let mut deserialized_messages: Vec<AnySyncMessageEvent> = messages\n+ Msg::NewMessage(Response::Sync((room_id, raw_msg))) => {\n+ // TODO handle all events\n+ if let Ok(msg) = raw_msg.deserialize() {\n+ if self.state.events.contains_key(&room_id) {\n+ if !(self.state.events[&room_id]\n .iter()\n- .map(|x| x.deserialize())\n- .filter_map(Result::ok)\n- .map(|x| x.without_room_id())\n- .collect();\n- // This is a clippy false positive\n- #[allow(clippy::map_entry)]\n- if self.state.events.contains_key(&room_id) {\n- self.state\n- .events\n- .get_mut(&room_id)\n- .unwrap()\n- .append(deserialized_messages.as_mut());\n- true\n+ .any(|x| x.event_id() == msg.event_id()))\n+ {\n+ self.state.events.get_mut(&room_id).unwrap().push(msg);\n+ room_id == self.props.current_room.room_id\n } else {\n- self.state.events.insert(room_id, deserialized_messages);\n- true\n+ false" 25 } 26 ] 27 }